add quotes around all arguments, to prevent args getting split incorrectly#1
Merged
add quotes around all arguments, to prevent args getting split incorrectly#1
Conversation
hazre
approved these changes
Sep 11, 2025
Member
hazre
left a comment
hazre
left a comment
There was a problem hiding this comment.
I tested it locally and seems to work. lgtm
GetCommandLineArgs stripes out the quotations, which is what we trying to prevent
Member
|
I changed out
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now I'm pretty sure this doesn't work exactly if your arguments actually include quotes.
for example
hello"worldwould get escaped as"hello"world"which idk how this gets parsed into arguments, maybehello,world". not sure but I'm not gonna test or fix it, someone else can do it. anyway you'd have to be a psycho to put quotes in the middle of any of these launch args